Prevent Stuck Scroller When Trying To Move Programattically #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ations added boolean option continuousScroll. Added new functions continuousScrollRight, continuousScrollLeft. Changed the algorithm for hotspot hovering speed ramp on the left hotspot (scrollingHotSpotLeft "mouse move")
…ations added boolean option continuousScroll. Added new functions continuousScrollRight, continuousScrollLeft. Changed the algorithm for hotspot hovering speed ramp on the left hotspot (scrollingHotSpotLeft "mouse move")
added boolean option continuousScrolling. Added new functions continuousScrollingRight, continuousScrollingLeft.
added boolean option continuousScrolling. Added new functions continuousScrollingRight, continuousScrollingLeft.
Added a quick check for < 0 to set el.data("scrollXPos") to 1 instead
of 0 (included in the check for Infinity)
Added a quick check for < 0 to set el.data("scrollXPos") to 1 instead
of 0 (included in the check for Infinity)
Removing the beta designation for pull request
Removing the beta designation for pull request
Deleting 1.2.js and going to add changes later.
Deleting 1.2.js and going to add changes later.
Minor logic fix to make the scrolling hotspots start scrolling right on the edge of the hotspot.
Minor logic fix to make the scrolling hotspots start scrolling right on the edge of the hotspot.
Fixes typo involved in the fixes made for more precise hotspot scroll start.
Fixes typo involved in the fixes made for more precise hotspot scroll start.
Added setupComplete trigger and Makefile that uses uglify.js
Many new features added and irritating issues fixed. Check the README.md file for all the info.
Autoscroll didn't stop when the user interacted with the scroller using touch.
While writing the documentation I found some issues that I fixed.
Plugin now recalculates scrollable area every time content is loaded using AJAX.
Conflicts: js/jquery.smoothDivScroll-1.3.js
Conflicts: js/jquery.smoothDivScroll-1.3.js
When attempting to move the scroller programatically, if
manualContinuousScrolling is enabled, the scroller will not move if the
scroller is at scrollLeft() == 0 initially (at the first element in the
scroller). I added an initial check to see if swapping should occur
before attempting to move so as to allow the continuous action to occur.
It is not perfect as this will only account for one position worth of
scrolling and attempting to use a step:function during animation seems
to not work because el.data("scrollWrapper").scrollLeft() does not seem
to update properly after swapping so it will scroll for as many steps
in the animation after scrollLeft() == 0.
When attempting to move the scroller programatically, if
manualContinuousScrolling is enabled, the scroller will not move if the
scroller is at scrollLeft() == 0 initially (at the first element in the
scroller). I added an initial check to see if swapping should occur
before attempting to move so as to allow the continuous action to occur.
It is not perfect as this will only account for one position worth of
scrolling and attempting to use a step:function during animation seems
to not work because el.data("scrollWrapper").scrollLeft() does not seem
to update properly after swapping so it will scroll for as many steps
in the animation after scrollLeft() == 0.
This reverts commit 5e6897c.
This reverts commit 09820ee.
This reverts commit 671b2ea.
This reverts commit 4f7ca5a.
This reverts commit 671b2ea.
This reverts commit 09820ee.
This reverts commit 3d01c5b.
This reverts commit 135c8bc.
This reverts commit d6648b7.
This reverts commit 4f7ca5a.
This reverts commit 671b2ea.
This reverts commit 09820ee.
This reverts commit 5e6897c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to move the scroller programatically, if
manualContinuousScrolling is enabled, the scroller will not move if the
scroller is at scrollLeft() == 0 initially (at the first element in the
scroller). I added an initial check to see if swapping should occur
before attempting to move so as to allow the continuous action to occur.
It is not perfect as this will only account for one position worth of
scrolling and attempting to use a step:function during animation seems
to not work because el.data("scrollWrapper").scrollLeft() does not seem
to update properly after swapping so it will scroll for as many steps
in the animation after scrollLeft() == 0.
Sorry for the huge amounts of commits. It has been a weird journey merging and such. A rebase was not exactly working. Hopefully this doesn't conflict.