Skip to content

Commit

Permalink
"The DifferenceZero property does not match the comment. The property…
Browse files Browse the repository at this point in the history
… should ensure that the number of sentUnacked messages equals the sum of msgs and acks for any edge, not the difference being zero."
  • Loading branch information
lemmy committed Dec 6, 2023
1 parent ae3c810 commit df7f099
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
12 changes: 6 additions & 6 deletions specifications/ewd687a/EWD687a.tla
Original file line number Diff line number Diff line change
Expand Up @@ -395,14 +395,14 @@ Spec == Init /\ [][Next]_vars /\ WF_vars(Next)
----------------------------------------------------------------------------

(***************************************************************************)
(* Messages are never lost, thus, the difference of msgs[e], acks[e], *)
(* sentUnacked[e], and rcvdUnacked[e] for any e in Edges is always zero. *)
(* EWd687a assumes messages are not lost. Thus, the four counters always *)
(* have to be consistent, i.e., the sum of msgs[e], acks[e], and *)
(* rcvdUnacked[e] equals sentUnacked[e], for any e in Edges. *)
(***************************************************************************)
DifferenceZero ==
[] \A e \in Edges:
(sentUnacked[e] - msgs[e] - rcvdUnacked[e] - acks[e]) = 0
CountersConsistent ==
[] \A e \in Edges: sentUnacked[e] = rcvdUnacked[e] + acks[e] + msgs[e]

THEOREM Spec => DifferenceZero
THEOREM Spec => CountersConsistent

(***************************************************************************)
(* The overlay tree is a tree of non-neutral nodes rooted in the leader, *)
Expand Down
2 changes: 1 addition & 1 deletion specifications/ewd687a/EWD687a_anim.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ INVARIANT

PROPERTY
DT2
\* DifferenceZero
\* CountersConsistent
\* TreeWithRoot
\* StableUpEdge

Expand Down
2 changes: 1 addition & 1 deletion specifications/ewd687a/MCEWD687a.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ PROPERTY
DT2

PROPERTIES
DifferenceZero
CountersConsistent
TreeWithRoot
\* StableUpEdge

Expand Down

1 comment on commit df7f099

@lemmy
Copy link
Member Author

@lemmy lemmy commented on df7f099 Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.