Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP according to RFC 9293. #131

Merged
merged 4 commits into from
Apr 6, 2024
Merged

TCP according to RFC 9293. #131

merged 4 commits into from
Apr 6, 2024

Conversation

lemmy
Copy link
Member

@lemmy lemmy commented Apr 5, 2024

[Feature]

@lemmy lemmy force-pushed the mku-tcp branch 5 times, most recently from ed349e1 to 3d00359 Compare April 5, 2024 16:57
@lemmy
Copy link
Member Author

lemmy commented Apr 6, 2024

TODO: Add Apalache type annotations

Copy link
Collaborator

@muenchnerkindl muenchnerkindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few initial questions about the spec ...

specifications/tcp/tcp.tla Outdated Show resolved Hide resolved
specifications/tcp/MCtcp.tla Show resolved Hide resolved
specifications/tcp/tcp.tla Outdated Show resolved Hide resolved
specifications/tcp/tcp.tla Show resolved Hide resolved
specifications/tcp/tcp.tla Show resolved Hide resolved
specifications/tcp/tcp.tla Show resolved Hide resolved
[Feature]

Signed-off-by: Markus Alexander Kuppe <[email protected]>
…eneric one (both CLOSED, no TCB, and empty network).

Signed-off-by: Markus Alexander Kuppe <[email protected]>
@lemmy lemmy force-pushed the mku-tcp branch 2 times, most recently from cdd3408 to 0b29a5b Compare April 6, 2024 20:25
Signed-off-by: Markus Alexander Kuppe <[email protected]>
@lemmy lemmy marked this pull request as ready for review April 6, 2024 23:40
@lemmy lemmy merged commit 33ff1af into tlaplus:master Apr 6, 2024
3 checks passed
@lemmy lemmy deleted the mku-tcp branch April 6, 2024 23:41
Copy link
Collaborator

@muenchnerkindl muenchnerkindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except I don't understand your combination of initial condition and action constraint anymore.


Init ==
/\ tcb = [p \in Peers |-> FALSE]
/\ connstate = [p \in Peers |-> "CLOSED"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this initial condition, does your action constraint still make sense, given that ACTIVE_OPEN and PASSIVE_OPEN are the only actions enabled from connection state CLOSED?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With TLC, Init is redefined by MCInit in MCtcp.tla.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants