Add BufferedRandomAccessFile spec #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Calvin Loncaric <[email protected]>
|
Duplication of the specification, both here and in the tlaplus/tlaplus repository, likely won't be an issue. However, it's important to note that the Consider adding a comment to the spec in tlaplus/tlaplus that points to the copy here. |
This tag isn't quite correct; the spec checks _action_ properties, not full liveness properties. But it is true that the spec uses the `[]` operator and the config file uses the `PROPERTY` keyword. Signed-off-by: Calvin Loncaric <[email protected]>
|
This is very weird. CI has SANY output the following error:
Will investigate. |
ahelwer
reviewed
Jun 16, 2024
Signed-off-by: Calvin Loncaric <[email protected]>
Calvin-L
force-pushed
the
bufferedrandomaccessfile
branch
from
563b1a0
to
4fb4032
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In review, @lemmy suggested adding this spec to our examples: tlaplus/tlaplus#907 (comment)
I made two small changes:
MaxOffsetfrom 4 to 3 so it can be checked in <10s (er, on my 8-core laptop anyway)