Use macOS runner, minor script debug output fixes #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What does the minor script fix do? |
ahelwer
force-pushed
the
minor-script-changes
branch
from
63c19f6
to
dd7d760
Compare
|
Sometimes (varies depending on OS and also way in which the process terminated) stdout is given in bytes, and sometimes it's given as a string. So this just ensures it's always printed out as a string in the smoke testing script. |
Signed-off-by: Andrew Helwer <[email protected]>
ahelwer
force-pushed
the
minor-script-changes
branch
from
dd7d760
to
e18823b
Compare
|
I'd suggest to make that the git commit message for that particular change. |
|
Sure, I will put that in the squash commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print out TLC command line call in smoke testing script and decode TLC output as UTF-8 if necessary.
Ref #119