Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tar CI failure on windows #83

Merged
merged 14 commits into from
Jul 28, 2023
Merged

Fix tar CI failure on windows #83

merged 14 commits into from
Jul 28, 2023

Conversation

ahelwer
Copy link
Collaborator

@ahelwer ahelwer commented Jul 27, 2023

I think the lesson here is don't try to use tar on windows. Should probably do a squash-merge because a lot of these commits were small changes trying to get the CI to pass.

Signed-off-by: Andrew Helwer <[email protected]>
Signed-off-by: Andrew Helwer <[email protected]>
Signed-off-by: Andrew Helwer <[email protected]>
Signed-off-by: Andrew Helwer <[email protected]>
Signed-off-by: Andrew Helwer <[email protected]>
Signed-off-by: Andrew Helwer <[email protected]>
Signed-off-by: Andrew Helwer <[email protected]>
Signed-off-by: Andrew Helwer <[email protected]>
Signed-off-by: Andrew Helwer <[email protected]>
Signed-off-by: Andrew Helwer <[email protected]>
@ahelwer
Copy link
Collaborator Author

ahelwer commented Jul 28, 2023

@lemmy what do you make of this failure in the windows CI?

Error: TLC threw an unexpected exception.
This was probably caused by an error in the spec or model.
See the User Output or TLC Console for clues to what happened.
The exception was a java.lang.UnsupportedClassVersionError
: org/jungrapht/visualization/layout/algorithms/LayoutAlgorithm has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

@lemmy
Copy link
Member

lemmy commented Jul 28, 2023

TLC should be running with at least Java 11.

@lemmy
Copy link
Member

lemmy commented Jul 28, 2023

Can this PR be merged or is the class version mismatch an issue?

@ahelwer
Copy link
Collaborator Author

ahelwer commented Jul 28, 2023

I think this can be merged. It's a bit worrying to have a transient java version issue but I added a line to print out the java version to the CI so at least if it happens again we'll have a lead on why.

@lemmy lemmy merged commit 55413d0 into tlaplus:master Jul 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants