Add skip parameter to python scripts #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Helwer <[email protected]>
Signed-off-by: Andrew Helwer <[email protected]>
Signed-off-by: Andrew Helwer <[email protected]>
Signed-off-by: Andrew Helwer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These python scripts are being consumed by more and more repositories with different needs. It therefore makes sense to move the skip/exclude lists out of the scripts themselves and into the CI, with the scripts taking them as a parameter. Primarily these changes are motivated by wanting to merge tlaplus/tlapm#96
Note these changes will break the tlaplus/tlaplus CI so that CI should be changed right after merging the changes in this one: tlaplus/tlaplus#844
In the course of these changes it was also discovered that all the specs in ewd998 parse correctly. Whether this is due to changes in the tools or the community modules I don't know, but TLAPS has not changed so it must be one of them (or there's an error happening that the scripts aren't catching). So anyway this closes #66.