-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: quoting of environment variables for CI, and automatically run release.yml
#68
base: main
Are you sure you want to change the base?
Conversation
84f6874
to
0bbd7e3
Compare
@johnyf could you rebase these on the current CI files to see whether these changes should be merged? |
0bbd7e3
to
397a092
Compare
Rebased the changes onto branch
|
Thanks for doing the rebase!
P.S. there's a requirement to sign your commits with a DCO (basically just saying you personally wrote this code and can legally contribute it and it isn't copied from a proprietary codebase or whatever), the github CI failure should have a link telling you how to retroactively add a DCO signoff to your commits. |
that is created by the CI workflow defined in the configuration file `.github/workflows/release.yml`. Also, place `UTC` between date and time substrings. Tags created after the above changes have the form: `YEAR_MM_DD_UTC_HH_MM` For example: `2022_06_20_UTC_01_00` Signed-off-by: Ioannis Filippidis <[email protected]>
Signed-off-by: Ioannis Filippidis <[email protected]>
Signed-off-by: Ioannis Filippidis <[email protected]>
to run semiyearly. Signed-off-by: Ioannis Filippidis <[email protected]>
upon failure of any tests. Signed-off-by: Ioannis Filippidis <[email protected]>
397a092
to
c26e347
Compare
Yes, the original fix for quoting environment variables was to code that is not in the current |
In #92 there was discussion of moving to a rolling release model (which I have really been dragging my feet on getting around to doing). So I think people want to keep the current release model then transition to that one, instead of releasing every six months + whenever release.yml is modified. However, I like all the other changes! |
Also @damiendoligez as FYI, I believe this is the issue you mentioned in the last community meeting |
BUG: correct quoting of environment-variable values in the script
setup_shell_env.py
, to avoid errors in CI workflow ofrelease.yml
.run workflow of file
.github/workflows/release.yml
whenever the file changes, and also twice a year.add underscores and "UTC" to tag name created by GitHub Actions when running
release.yml
.