-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language Server Protocol for TLAPM #93
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kape1395
force-pushed
the
lsp
branch
3 times, most recently
from
October 17, 2023 04:53
fc73d21
to
dd82fcd
Compare
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Co-authored-by: Damien Doligez <[email protected]> Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Co-authored-by: Damien Doligez <[email protected]> Signed-off-by: Karolis Petrauskas <[email protected]>
Co-authored-by: Damien Doligez <[email protected]> Signed-off-by: Karolis Petrauskas <[email protected]>
Co-authored-by: Damien Doligez <[email protected]> Signed-off-by: Karolis Petrauskas <[email protected]>
Co-authored-by: Damien Doligez <[email protected]> Signed-off-by: Karolis Petrauskas <[email protected]>
Co-authored-by: Damien Doligez <[email protected]> Signed-off-by: Karolis Petrauskas <[email protected]>
Co-authored-by: Damien Doligez <[email protected]> Signed-off-by: Karolis Petrauskas <[email protected]>
Co-authored-by: Damien Doligez <[email protected]> Signed-off-by: Karolis Petrauskas <[email protected]>
Co-authored-by: Damien Doligez <[email protected]> Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
damiendoligez
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This concludes my review. Good to merge after you look at these last few comments.
Signed-off-by: Karolis Petrauskas <[email protected]>
…stdin` option. Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
Signed-off-by: Karolis Petrauskas <[email protected]>
… final state. Signed-off-by: Karolis Petrauskas <[email protected]>
@damiendoligez, it seems I updated the PR according to all the comments. Thanks; they were all helpful. |
Signed-off-by: Karolis Petrauskas <[email protected]>
Minor regression: #149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are over #83 and #91. Closes #90 and #94. The corresponding client part for the VSCode extension is already merged as tlaplus/vscode-tlaplus#307.
tlapm
as a sub-process.tlapm
are:From the functionality perspective:
ctrl+g+g
or via the code action (yellow lamp along the cursor position).