Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speedtest-rs: add page #15193

Merged
merged 10 commits into from
Dec 21, 2024
Merged

Conversation

Abhishek-1804
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Dec 18, 2024
@Abhishek-1804 Abhishek-1804 changed the title speedtest-rs: add-page speedtest-rs: add page Dec 18, 2024
@Abhishek-1804 Abhishek-1804 force-pushed the add-speedtest-rs-command branch from b8923c6 to 36489b5 Compare December 18, 2024 15:35
@Abhishek-1804 Abhishek-1804 force-pushed the add-speedtest-rs-command branch from 20e2317 to 03dcb15 Compare December 18, 2024 15:37
@Abhishek-1804
Copy link
Contributor Author

Abhishek-1804 commented Dec 18, 2024

@cyqsimon @sebastiaanspeck @acuteenvy Hi, Could you please review this pr?

Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have two minor suggestions.

pages/common/speedtest-rs.md Outdated Show resolved Hide resolved
pages/common/speedtest-rs.md Outdated Show resolved Hide resolved
@Abhishek-1804 Abhishek-1804 force-pushed the add-speedtest-rs-command branch from ad63cbb to 7045ceb Compare December 19, 2024 18:09
@Managor
Copy link
Collaborator

Managor commented Dec 20, 2024

speedtest and speedtest-rs seem to have indentical syntax. These pages should be merged and speedtest-rs be made into an alias.

@Managor
Copy link
Collaborator

Managor commented Dec 20, 2024

#14804

@Abhishek-1804
Copy link
Contributor Author

speedtest and speedtest-rs seem to have indentical syntax. These pages should be merged and speedtest-rs be made into an alias.

While speedtest-rs and speedtest-cli might seem similar, they’re not aliases. speedtest-rs is written in Rust and was created as a learning project, focusing on HTTP Legacy Fallback. It’s missing features like TCP-based connections and Speedtest Mini support, which speedtest-cli includes. These differences make them separate tools with distinct implementations.

@Managor
Copy link
Collaborator

Managor commented Dec 20, 2024

I see, thank you. Could you be available to modify the page for speedtest so that these pages are more uniform? According to that issue, the examples are not functional.

@Abhishek-1804
Copy link
Contributor Author

I understand the confusion now. I’ll update the documentation to make the distinction between speedtest, speedtest-cli, and speedtest-rs clearer, especially with regard to different systems where speedtest might point to non- Ookla tools like the GUI-based librespeed

@Managor Managor merged commit 215ae8f into tldr-pages:main Dec 21, 2024
4 checks passed
@Abhishek-1804 Abhishek-1804 deleted the add-speedtest-rs-command branch December 21, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants