Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rails-server: add page #15590

Merged
merged 5 commits into from
Jan 26, 2025

Conversation

nelsonfigueroa
Copy link
Collaborator

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.

@github-actions github-actions bot added new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers. labels Jan 23, 2025
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/rails-server.md:24:21 MD047/single-trailing-newline Files should end with a single newline character
pages/common/rails-server.md:1: TLDR009 Page should contain a newline at end of file

Please fix the error(s) and push again.

Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which pages does thhis server serve? The current directory, such as python -m http.server?

@nelsonfigueroa
Copy link
Collaborator Author

Which pages does thhis server serve? The current directory, such as python -m http.server?

@gutjuri Yeah it's the current directory. Maybe I can update the description at the top? Something like: "Serve the Rails app in the current directory using the Puma web server, which comes bundled with Rails."

@nelsonfigueroa
Copy link
Collaborator Author

Thanks for the review everyone. This should be good to go now.

pages/common/rails-server.md Outdated Show resolved Hide resolved
@nelsonfigueroa nelsonfigueroa merged commit 7fd944e into tldr-pages:main Jan 26, 2025
4 checks passed
@nelsonfigueroa nelsonfigueroa deleted the rails-server-add-page branch January 26, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants