Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/ollama_functions_example: improve system message for better response #951

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shmsr
Copy link

@shmsr shmsr commented Jul 8, 2024

For llama3, the example seemed to work but for some other models like qwen2 and friends, it was not working properly. I faced issues where getCurrentWeather tool worked but not the finalResponse tool. With these changes, I can get the desired behavior.

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

For llama3, the examples seemed to but for some other models like qwen2 and friends, it was not working properly. I faced issues where `getCurrentWeather` tool worked but not the `finalResponse` tool. With these changes, I am able to get the desired behaviour.
@shmsr shmsr changed the title Improve system message for better response examples/ollama_functions_example: improve system message for better response Jul 8, 2024
@shmsr
Copy link
Author

shmsr commented Jul 25, 2024

@corani Can you PTAL?

@shmsr
Copy link
Author

shmsr commented Sep 13, 2024

friendly ping

@corani
Copy link
Contributor

corani commented Sep 16, 2024

Looks fine to me, but it's up to @tmc to decide 😉

@treywelsh treywelsh mentioned this pull request Sep 23, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants