Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

milvus: Avoid crashing when empty documents are supplied to AddDocuments #959

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

milvus: Avoid crashing when empty documents are supplied to AddDocuments #959

wants to merge 2 commits into from

Commits on Aug 23, 2024

  1. milvus: Return early when documents are empty 

    Some procedures (like LoadAndSplit of documentsloaders.Loader) might
end up creating an empty documents list. This is handled gracefully
in other vectorstores (like chroma), but not in milvus due
to the len(vectors[0]) piece further in AddDocuments.
    @AloizioMacedo
    AloizioMacedo committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    4a54055 View commit details
    Browse the repository at this point in the history

  2. milvus: Add test for empty documents

    @AloizioMacedo
    AloizioMacedo committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    830fa02 View commit details
    Browse the repository at this point in the history