Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IsolationLevel optional parameter to GetTransactionAsync and Begin... #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pavick
Copy link

@pavick pavick commented Mar 25, 2015

...TransactionAsync

The default isolation level is read committed.

…ginTransactionAsync

The default isolation level is read committed.
@tmenier
Copy link
Owner

tmenier commented May 9, 2015

Sorry about the delay. I've not seen it documented that ReadCommitted is the default isolation level for any db other that SQL Server, so I'm not sure I agree with the implementation. I'm on board with the idea but I think it needs to defer to the provider for the default rather than hard-coding to ReadCommitted.

@pavick
Copy link
Author

pavick commented May 9, 2015

I understand. In that case the easiest thing to do would be to overload the Transaction methods with methods that have a required IsolationLevel parameter.

@tmenier
Copy link
Owner

tmenier commented Aug 12, 2016

Sorry for dropping the ball on this. If it's still something you're interested in I'm willing to accept this and make a few tweaks so as not to assume ReadCommitted is the default. Let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants