TTS #375

anderoonies · 2021-07-31T23:55:57Z

see diff at https://github.com/flend/brogue-1.7.4/compare/feature/brogue174-SPEAKv03?expand=1&w=1

speech for locations and messages
figure out ifdef/endifs best practices
rest of sayIts from diffs
code cleanup and styling
figure out stripping formatting characters
instructions for local setup of espeak
interruptable and non-interruptable messages?

anderoonies · 2021-08-01T02:42:34Z

can anyone with a Brogue-SPEAK installation let me know how cursor mode works? currently, nothing is speaking in cursor mode, i believe that it should be speaking any tiles that's different than the previous. resolved

…sages

withinwheels · 2021-08-02T03:36:16Z

src/brogue/IO.c

@@ -3474,7 +3479,7 @@ void flavorMessage(char *msg) {
 // arrived on the same turn, they may collapse.  Alternately, they may collapse
 // if the older message is the latest one in the archive and the new one is not
 // semi-colon foldable (such as a combat message.)
-void message(const char *msg, enum messageFlags flags) {
+void message(const char *msg, enum messageFlags flags, short speechPriority) {


Any reason to not fold speechPriority into the other messageFlags? With a judicious default it could probably save touching a lot of message call sites.

a great idea, i wanted to avoid modifying the existing enum, but that handles a default much better

withinwheels · 2021-08-02T03:37:01Z

src/brogue/Globals.c

@@ -189,7 +189,7 @@ const color fireForeColor =         {70,    20,     0,      15,     10,
 const color lavaForeColor =         {20,    20,     20,     100,    10,         0,          0,      true};
 const color brimstoneForeColor =    {100,   50,     10,     0,      50,         40,         0,      true};
 const color brimstoneBackColor =    {18,    12,     9,      0,      0,          5,          0,      false};
-
+                                //Red     Green   Blue    RedRand GreenRand   BlueRand    Rand    Dances


This seems unrelated.

yeah i'm not sure where this came from, probably the IDE doing something.

withinwheels · 2021-08-02T03:40:23Z

src/platform/main.c

@@ -252,6 +252,8 @@ int main(int argc, char *argv[])
            continue;
        }

+        rogue.trueColorMode = false;


Is this related?

the existing BrogueSPEAK implementation manually turns all trueColorMode checks to false checks, essentially skipping any code that deals with trueColorMode. i'm not yet positive the reason for it, i'm guessing it's not related to TTS, maybe just a simplification. this should be conditionally false based on whether this is BROGUE_SPEECH mode, i just removed all of my #ifdef BROGUE_SPEECH for now because VScode wasn't seeing my defines.

I think it does that to simply hard-code colour effects off, to increase clarity for partially sighted players. IIRC there are other small visual improvements to that effect in Brogue-SPEAK

cool, sounds good to me. if you have suggestions on how to do the checks with the compile flags lmk, my strategy was just like

#ifdef BROGUE_SPEECH rogue.trueColorMode = false #endif

or whatever.
VScode wasnt able to handle that properly so i dropped it for now, but if there's a better way i'll do that

also going to be busy for the next few days, should be able to work a bit more on this over the weekend

It would be a shame if the TTS features required a recompile (which using #define would imply.) Maybe we can arrange for it to be {dis,en}abled with a command line flag and/or key binding?

Alternately I'd be interesting in seeing what happens if we just leave true color mode alone; maybe it's fine?

if the TTS features required a recompile

I suppose another way to say this is it would be nice if we could distribute just one binary, and have it serve both users who want TTS, and users who want true color.

anderoonies · 2021-08-03T12:30:20Z

I’ll see about toggling TTS just the same as graphics, yeah. TTS needs SDL, so it would need to have been compiled with graphics, but I believe the main distribution is? I’m inclined to trust the author of Brogue-SPEAK on true color, doesn’t need to be removed in the first draft of TTS but I think it’s probably something they learned from playtesting with visually impaired people. I’ll see about getting people to playtest, too

…

On Tue, Aug 3, 2021 at 12:40 AM withinwheels ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/platform/main.c <#375 (comment)>: > @@ -252,6 +252,8 @@ int main(int argc, char *argv[]) continue; } + rogue.trueColorMode = false; if the TTS features required a recompile I suppose another way to say this is it would be nice if we could distribute just one binary, and have it serve both users who want TTS, and users who want true color. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#375 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABSWLAM2QDVXMMZBQSTU22LT25XLNANCNFSM5BKP4PQA> .

anderoonies · 2021-08-08T22:15:14Z

alright, i have priority/flags folded into messageFlags, but still not sure about how many priority levels will be needed and which kind of messages need which priority. i'm going to test some and see about distributing it to people on the audiogames forum for testing.
i'm still having issues with espeak-ng on my machine so it's been very spotty whether i can actually run this (issue here espeak-ng/espeak-ng#996), so if anyone wants to test and see how the current speech feels please lmk

anderoonies · 2021-08-08T22:19:24Z

additionally TTS is toggled at runtime with !

withinwheels · 2021-08-09T01:36:05Z

config.mk

 # Enable debugging mode. See top of Rogue.h for features
-DEBUG := NO
+DEBUG := YES


I imagine this line will need to revert dropped before merge.

withinwheels · 2021-08-09T01:38:24Z

src/brogue/Movement.c

+    char locationMessage[DCOLS*3];
+
+    if(strlen(locationDescription) < 2) {
+        strcpy(locationMessage, "Blank.");


"Nothing" or "empty ground" might be more thematic.

withinwheels · 2021-08-09T01:43:55Z

src/platform/sdl2-platform.c

+
+        sanitizedMessage[j++]= text[i];
+    }
+    printf(sanitizedMessage);


This printf seems like it will interfere with console interfaces. Is it just debug logging that can be removed?

yep! still just figuring out some bugs. occasionally there's some garbage synthesized that i need to figure out

tmewett and others added 3 commits July 30, 2021 20:40

Add basic eSpeak integration to SDL platform

9b966da

First work at TTS prompts in Brogue Speech

578dcd9

Remove ifdef guards for speech now, sanitize speech in one place

debcd07

anderoonies added 3 commits July 31, 2021 22:44

Speak location information in cursor mode

0b25910

Fuller location speech, groundwork for interrupting/interruptable mes…

f428261

…sages

First pass at speech message priority for interrupting/blocking

a413c69

withinwheels reviewed Aug 2, 2021

View reviewed changes

enum for speech priority and flags for blocking speech

748f54e

anderoonies force-pushed the feature/audio branch from e7ff7ef to 748f54e Compare August 8, 2021 22:13

withinwheels reviewed Aug 9, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TTS #375

TTS #375

anderoonies commented Jul 31, 2021 •

edited

Loading

anderoonies commented Aug 1, 2021 •

edited

Loading

withinwheels Aug 2, 2021

anderoonies Aug 2, 2021

withinwheels Aug 2, 2021

anderoonies Aug 2, 2021

withinwheels Aug 2, 2021

anderoonies Aug 2, 2021

tmewett Aug 2, 2021

anderoonies Aug 3, 2021

anderoonies Aug 3, 2021

withinwheels Aug 3, 2021

withinwheels Aug 3, 2021

anderoonies commented Aug 3, 2021 via email

anderoonies commented Aug 8, 2021

anderoonies commented Aug 8, 2021

withinwheels Aug 9, 2021

withinwheels Aug 9, 2021

withinwheels Aug 9, 2021

anderoonies Aug 9, 2021

TTS #375

Are you sure you want to change the base?

TTS #375

Conversation

anderoonies commented Jul 31, 2021 • edited Loading

anderoonies commented Aug 1, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anderoonies commented Aug 3, 2021 via email

anderoonies commented Aug 8, 2021

anderoonies commented Aug 8, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anderoonies commented Jul 31, 2021 •

edited

Loading

anderoonies commented Aug 1, 2021 •

edited

Loading