Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use 'pos' type to look up terrain flag values #624

Merged
merged 2 commits into from
Nov 27, 2023
Merged

use 'pos' type to look up terrain flag values #624

merged 2 commits into from
Nov 27, 2023

Conversation

Nathan-Fenner
Copy link
Contributor

Almost all of the individual call-sites were refactored with a smart find+replace regex, so there shouldn't be any accidental typos.

Three functions have been refactored to take pos arguments instead of short, short coordinates:

  • terrainFlags
  • terrainMechFlags
  • cellHasTerrainFlag

flend
flend requested changes Nov 25, 2023
View reviewed changes
src/brogue/Monsters.c Outdated Show resolved Hide resolved
@tmewett
Copy link
Owner

tmewett commented Nov 27, 2023

LGTM

@tmewett tmewett merged commit 565e479 into tmewett:release Nov 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flend flend Awaiting requested review from flend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nathan-Fenner @tmewett @flend