create struct screenDisplayBuffer
type (cellDisplayBuffer[COLS][ROWS] ---> screenDisplayBuffer
)
#625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, most of the time, a
cellDisplayBuffer buf[COLS][ROWS]
was created wherever needed. Now, you can spell this asscreenDisplayBuffer buf;
There are a few ways that this is nicer:
[COLS][ROWS]
every timeThis PR just swaps out all of the existing
cellDisplayBuffer
arrays to references to this new type. There's no other changes.Eventually, I'd like to refactor a bit more, so that the screen is more "encapsulated" - references to
.cells
should be restricted to a handful of functions, so that the screen buffer can become a higher-level data structure (e.g. we could eventually store info about "layers" or "effects" to make the view prettier on platforms that support it). Having a consistent "screen" type is an important basic step to make that happen.