Fix unused function and missing prototype warnings #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flend
reviewed
Nov 25, 2023
| //DEBUG displayWaypoints(); | ||
| DEBUG displayWaypoints(); | ||
|
|
||
| #ifdef LOG_LIGHTS |
There was a problem hiding this comment.
The indentation looks a little off here
There was a problem hiding this comment.
Fixed the indentation on the logLights() line. Having no indentation for the preprocessor directives seems standard though.
There was a problem hiding this comment.
I presume @tmewett means he prefers the new indentation, rather than wanting no indentation?
There was a problem hiding this comment.
I mean that I agree it's typical for preprocessor directives to have no indentation - diff as-is looks good to me
Some of these warnings were directly introduced in tmewett#593; others are due to other PRs that were merged between when I made that PR and when it was merged. Some of these are fixed with new `#define`s; this also makes `displayLoops` and `displayChokeMap` static and always runs them in wizard mode when '~' is pressed, along with `displayMachines` and `displayWaypoints`. This also improves those functions a bit, so it's easier to tell which output is from which function.
nstoddard
force-pushed
the
fix-warnings
branch
from
71eca4f
to
5e48c19
Compare
tmewett
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these warnings were directly introduced in #593; others are due to other PRs that were merged between when I made that PR and when it was merged.
Some of these are fixed with new
#defines; this also makesdisplayLoopsanddisplayChokeMapstatic and always runs them in wizard mode when '~' is pressed, along withdisplayMachinesanddisplayWaypoints. This also improves those functions a bit, so it's easier to tell which output is from which function.