Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo the level if stairs cannot be placed #635

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

flend
Copy link
Collaborator

@flend flend commented Dec 9, 2023

Rapid Brogue seed 519 cannot place stairs in level 2 since there are no qualifying squares (basically every square is part of a machine). This patch rerolls the level when this (very rare) case occurs.

@nstoddard
Copy link
Contributor

Does this fix #536 too?

@flend
Copy link
Collaborator Author

flend commented Dec 9, 2023

Does this fix #536 too?

Yes, I didn't know the issue existed but I recreated the crash on v1.13 release and this patch fixes it.
The discussion in the ticket is interesting and you could make the machine-placing code more complex to avoid eating up all the level but I think this solution should be added in any case: it's more general and in-line with usual roguelike procgen practices.

@tmewett tmewett merged commit 83a1ffc into tmewett:release Dec 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants