Adding out-of-range guard to plotChar+ functions #636
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
getInputTextString
in debug builds would overwrite the edge of thedisplayBuffer
due to the use ofplotCharWithColor
. This happened, for example, when printing the default save file name for debug builds (which have long version strings).This change adds guarding to the
plotCharWithColor
andplotCharToBuffer
(which was already there but only as an assert for debug builds). I haven't changedplotChar
since it's a lower level function where the caller will have to take responsibility for not writing outside of bounds.