Adding github action to monitor for dungeon gen changes #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flend
force-pushed
the
feature/seed_catalog_test
branch
2 times, most recently
from
39851be
to
40b02d2
Compare
tmewett
reviewed
Dec 21, 2023
flend
force-pushed
the
feature/seed_catalog_test
branch
from
40b02d2
to
3908cc0
Compare
Yeah, I will add a script in future to do this simply. |
flend
force-pushed
the
feature/seed_catalog_test
branch
3 times, most recently
from
df4f547
to
f830df7
Compare
flend
force-pushed
the
feature/seed_catalog_test
branch
from
f830df7
to
5b59ebb
Compare
|
Nice work, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new github action to check the output of seed catalog for each variant and fails if it has changed.
This will detect any unintentional changes to dungeon generation.
If any changes have expected dungeon generation changes, the commits also need to update
test/seed_catalogs.This test could apply to
masterbut requires the seed catalog crash fix which is only currently inrelease.