-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add appstream metadata #710
base: release
Are you sure you want to change the base?
Conversation
55355b8
to
7ab38b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment
7ab38b9
to
f141cd7
Compare
https://www.freedesktop.org/wiki/Distributions/AppStream/ Needed for this application to show up in various Linux software centers such as gnome-software and discover.
f141cd7
to
68e3e34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, and sorry for the very delayed review!
install -Dm644 $(metainfo_in) $(DESTDIR)$(metainfodir)/io.github.tmewett.brogue.metainfo.xml | ||
|
||
uninstall: | ||
rm -f $(DESTDIR)$(metainfodir)/io.github.tmewett.brogue.metainfo.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we remove all the Makefile changes for now - we don't really support this style of installing and I don't want to to be partial
I've changed the PR target branch to 'release', as per the contribution guide. You don't need to rebase the branch onto 'release', but you can if you want. |
https://www.freedesktop.org/wiki/Distributions/AppStream/
Needed for this application to show up in various Linux software centers such as gnome-software and discover.