Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appstream metadata #710

Open
wants to merge 1 commit into
base: release
Choose a base branch
from

Conversation

androidnisse
Copy link

https://www.freedesktop.org/wiki/Distributions/AppStream/

Needed for this application to show up in various Linux software centers such as gnome-software and discover.

Copy link
Collaborator

@flend flend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment

linux/io.github.tmewett.brogue.metainfo.xml Outdated Show resolved Hide resolved
https://www.freedesktop.org/wiki/Distributions/AppStream/

Needed for this application to show up in various Linux software centers such as gnome-software and discover.
Copy link
Owner

@tmewett tmewett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, and sorry for the very delayed review!

install -Dm644 $(metainfo_in) $(DESTDIR)$(metainfodir)/io.github.tmewett.brogue.metainfo.xml

uninstall:
rm -f $(DESTDIR)$(metainfodir)/io.github.tmewett.brogue.metainfo.xml
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we remove all the Makefile changes for now - we don't really support this style of installing and I don't want to to be partial

@tmewett tmewett changed the base branch from master to release November 13, 2024 10:33
@tmewett
Copy link
Owner

tmewett commented Nov 13, 2024

I've changed the PR target branch to 'release', as per the contribution guide. You don't need to rebase the branch onto 'release', but you can if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants