Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert v1.13.1's changes temporarily #811

Merged
merged 2 commits into from
Sep 10, 2022
Merged

Revert v1.13.1's changes temporarily #811

merged 2 commits into from
Sep 10, 2022

Conversation

tony
Copy link
Member

@tony tony commented Sep 10, 2022

The reason why is I have upcoming changes and refactorings (like #805) that are noops, and we should at least stay with the earlier broken behavior (the broken behavior we know) while we investigate a better way to do v1.13.1. Me and @nvasilas will release an improved solution

Revert "Fix layout related issues #737, #667, #704"

This reverts commit fb9a8af.

@codecov
Copy link

codecov bot commented Sep 10, 2022

Codecov Report

Merging #811 (f041c93) into master (d3d30fb) will not change coverage.
The diff coverage is 100.00%.

❗ Current head f041c93 differs from pull request most recent head 1efd8b3. Consider uploading reports for the commit 1efd8b3 to get more accurate results

@@           Coverage Diff           @@
##           master     #811   +/-   ##
=======================================
  Coverage   75.27%   75.27%           
=======================================
  Files          18       18           
  Lines        1436     1436           
  Branches      336      337    +1     
=======================================
  Hits         1081     1081           
  Misses        267      267           
  Partials       88       88           
Impacted Files Coverage Δ
tmuxp/workspacebuilder.py 85.57% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony merged commit 6e73a66 into master Sep 10, 2022
@tony tony deleted the revert-v1.13.1 branch September 10, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant