Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update path to example data in notebooks #357

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

w-k-jones
Copy link
Member

@w-k-jones w-k-jones commented Oct 25, 2023

Resolves #355

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

@w-k-jones w-k-jones self-assigned this Oct 25, 2023
@w-k-jones w-k-jones added bug Code that is failing or producing the wrong result Small Change A minor change which should be quick to address and review labels Oct 25, 2023
@w-k-jones w-k-jones added this to the Version 1.5.2 milestone Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f87ea1e) 55.75% compared to head (fbf2c06) 55.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           RC_v1.5.x     #357   +/-   ##
==========================================
  Coverage      55.75%   55.75%           
==========================================
  Files             15       15           
  Lines           3316     3316           
==========================================
  Hits            1849     1849           
  Misses          1467     1467           
Flag Coverage Δ
unittests 55.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JuliaKukulies
Copy link
Member

Thanks for fixing this quickly! So I guess we want to merge this one before #293

@w-k-jones w-k-jones merged commit b87ba6e into tobac-project:RC_v1.5.x Oct 27, 2023
7 checks passed
@JuliaKukulies JuliaKukulies mentioned this pull request Nov 8, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code that is failing or producing the wrong result Small Change A minor change which should be quick to address and review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants