Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version number, changelog and notebooks for 1.5.2 release #381

Merged
merged 6 commits into from
Dec 8, 2023

Conversation

w-k-jones
Copy link
Member

@w-k-jones w-k-jones commented Dec 6, 2023

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

@w-k-jones w-k-jones added this to the Version 1.5.2 milestone Dec 6, 2023
@w-k-jones w-k-jones self-assigned this Dec 6, 2023
@w-k-jones w-k-jones added the release Organising the next release on conda-forge label Dec 6, 2023
Copy link

github-actions bot commented Dec 6, 2023

Linting results by Pylint:

Your code has been rated at 8.72/10 (previous run: 8.72/10, +0.00)
The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the RC_v1.5.x branch.
A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (81ea461) 56.91% compared to head (47bd890) 56.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##           RC_v1.5.x     #381   +/-   ##
==========================================
  Coverage      56.91%   56.91%           
==========================================
  Files             20       20           
  Lines           3440     3440           
==========================================
  Hits            1958     1958           
  Misses          1482     1482           
Flag Coverage Δ
unittests 56.91% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@freemansw1 freemansw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, @w-k-jones

@w-k-jones w-k-jones mentioned this pull request Dec 6, 2023
8 tasks
Copy link
Member

@JuliaKukulies JuliaKukulies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for doing this @w-k-jones! Just add #384 to changelog as well once it is merged.

@w-k-jones w-k-jones merged commit 3484f95 into tobac-project:RC_v1.5.x Dec 8, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Organising the next release on conda-forge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants