-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: incomplete charges #109
Draft
tobiasehlert
wants to merge
12
commits into
main
Choose a base branch
from
feature-incomplete-charges
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Jul 20, 2021
-
Provide Access to Incomplete Charges
While these are usually charges that failed, they also include charges that are in progress. The client should be able to see these Charges and decide how to proceed. These charges were, at one point, real charges with relevant data. Reasons for failure: - Charging started, TeslaMate server or Tesla API went offline - Charging in progress (not actually failure, just incomplete charge data) This will also allow the user to know about the charge's existence and query (by ID) the Charge Details. Since the database stored the many charge detail objects, the user may be able to process some additional information about the charge. Especially if the charge is in progress. Example: 1. Charge is in progress. 2. Receive basic charge data, like start date and charge ID. 3. Query Charge Details to info like: start date, power over time, etc. However, even with access to this additional data that does exist, the user still will not be able to see data from when the charge went offline. Or in the case the charge is still occurring, the user can't see charge details that haven't happened yet. Therefore, Charge Details require an additional parameter `isCompleted:BOOL` so the user knows if an object is finalized. **The user will have to determine whether the charge is still in progress or corrupted, by seeing if there are any recent charges. If it's in progress, the user should consider refreshing that charge object in the future.** I chose to add this as a separate object on `Data` so that it will not affect existing API users. This will ensure incomplete charges are not treated as completed charges.
Configuration menu - View commit details
-
Copy full SHA for 542fc40 - Browse repository at this point
Copy the full SHA 542fc40View commit details
Commits on Jul 21, 2021
-
Update v1_TeslaMateAPICarsCharges.go
Finally got builds working on my local machine. Next few commits may to fix bugs from new code
Configuration menu - View commit details
-
Copy full SHA for df10ffc - Browse repository at this point
Copy the full SHA df10ffcView commit details -
Configuration menu - View commit details
-
Copy full SHA for a819f30 - Browse repository at this point
Copy the full SHA a819f30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80e6e72 - Browse repository at this point
Copy the full SHA 80e6e72View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a8554e - Browse repository at this point
Copy the full SHA 6a8554eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8740b29 - Browse repository at this point
Copy the full SHA 8740b29View commit details -
Alec O’Connor committed
Jul 21, 2021 Configuration menu - View commit details
-
Copy full SHA for c305182 - Browse repository at this point
Copy the full SHA c305182View commit details -
Alec O’Connor committed
Jul 21, 2021 Configuration menu - View commit details
-
Copy full SHA for d6359eb - Browse repository at this point
Copy the full SHA d6359ebView commit details -
Alec O’Connor committed
Jul 21, 2021 Configuration menu - View commit details
-
Copy full SHA for 8477384 - Browse repository at this point
Copy the full SHA 8477384View commit details
Commits on Aug 4, 2021
-
Existing issue, chargesdata is null when empty. To check, set ?page=10 and see the response. An empty array is more useful and clear
Alec O’Connor committedAug 4, 2021 Configuration menu - View commit details
-
Copy full SHA for fa8f611 - Browse repository at this point
Copy the full SHA fa8f611View commit details
Commits on Oct 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9da3cf2 - Browse repository at this point
Copy the full SHA 9da3cf2View commit details -
Merge pull request #93 from alecdoconnor/patch-3
Display incomplete charge data
Configuration menu - View commit details
-
Copy full SHA for 0dc4007 - Browse repository at this point
Copy the full SHA 0dc4007View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.