Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Userland app for servomotor #462

Merged
merged 13 commits into from
Jan 8, 2025

Conversation

inesmaria08
Copy link
Contributor

@inesmaria08 inesmaria08 commented Aug 2, 2024

This pull request adds an app that provides a simple interface to control the angle of a connected servomotor (tock/tock#4126).
Files added:

  • libtock/interface/syscalls/servo_syscalls.c
  • libtock/interface/syscalls/servo_syscalls.h
  • examples/servo/main.c
  • examples/servo/Makefile

libtock-sync/interface/servo.c Outdated Show resolved Hide resolved
libtock-sync/interface/servo.h Outdated Show resolved Hide resolved
libtock/interface/syscalls/servo_syscalls.c Outdated Show resolved Hide resolved
Copy link
Contributor

@alexandruradovici alexandruradovici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor changes.

examples/servo/main.c Outdated Show resolved Hide resolved
examples/servo/main.c Outdated Show resolved Hide resolved
examples/servo/main.c Show resolved Hide resolved
@alexandruradovici alexandruradovici added the blocked Blocked on promised changes or other PRs label Aug 13, 2024
@alexandruradovici
Copy link
Contributor

Blocking until the driver is modified to support more than one servo.

@alexandruradovici alexandruradovici removed the blocked Blocked on promised changes or other PRs label Oct 14, 2024
libtock/interface/syscalls/servo_syscalls.c Outdated Show resolved Hide resolved
libtock/interface/syscalls/servo_syscalls.c Outdated Show resolved Hide resolved
libtock/interface/syscalls/servo_syscalls.h Outdated Show resolved Hide resolved
libtock/interface/syscalls/servo_syscalls.h Outdated Show resolved Hide resolved
examples/servo/main.c Outdated Show resolved Hide resolved
Copy link
Member

@ppannuto ppannuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good — a few small style fixes.

This also needs a README explaining what the expectations are to run the test and an example of sample output from the test.

examples/servo/main.c Outdated Show resolved Hide resolved
libtock/interface/syscalls/servo_syscalls.c Outdated Show resolved Hide resolved
libtock/interface/syscalls/servo_syscalls.h Outdated Show resolved Hide resolved
libtock/interface/syscalls/servo_syscalls.c Outdated Show resolved Hide resolved
examples/servo/main.c Outdated Show resolved Hide resolved
examples/servo/main.c Outdated Show resolved Hide resolved
examples/servo/main.c Show resolved Hide resolved
@ppannuto
Copy link
Member

Code all looks good, only thing this still needs is a README for the example.

@alexandruradovici alexandruradovici added this pull request to the merge queue Jan 8, 2025
Merged via the queue into tock:master with commit 6a05dd2 Jan 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants