Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in project docs #17

Closed
wants to merge 2 commits into from
Closed

Conversation

ShaneCurcuru
Copy link

No description provided.

@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for ospoglossary ready!

Name Link
🔨 Latest commit da0c826
🔍 Latest deploy log https://app.netlify.com/sites/ospoglossary/deploys/651574a291a1cc0008663022
😎 Deploy Preview https://deploy-preview-17--ospoglossary.netlify.app/style-guide
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Author

@ShaneCurcuru ShaneCurcuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I add the DCO here? Or does it need to be in a completely separate commit? (Note: I use GitHub UI/Desktop, not git)

Signed-off-by: Shane Curcuru [email protected]

Lets see if this properly adds a DCO to the PR

Signed-off-by: Shane Curcuru <[email protected]>
@ShaneCurcuru
Copy link
Author

Is there any way to get the DCO check to re-run, so this is mergeable? Or should we just close this and I can start with a fresh copy of everything, and then remember to add the signoff?

Also, if this project - which wants to attract non-coders (i.e. people who will be using GitHub, not git, to contribute), then you should consider setting the GitHub repo to enforce signoffs:

https://github.blog/changelog/2022-06-08-admins-can-require-sign-off-on-web-based-commits/#how-to-enable-required-signoffs-for-a-repository

@caniszczyk
Copy link
Member

@ShaneCurcuru problem is first commit doesn't have the DCO so that's why it's still failing

We do enable this setting on all TODO repos btw :)

I think easiest option is to close this and resubmit the PR (cc: @anajsana to help out)

@ShaneCurcuru
Copy link
Author

Replaced by PR #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants