Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(server): use verificationToken model instead of tokenService #9657

Conversation

fengmk2
Copy link
Contributor

@fengmk2 fengmk2 commented Jan 13, 2025

No description provided.

@github-actions github-actions bot added app:server test Related to test cases labels Jan 13, 2025
@fengmk2 fengmk2 marked this pull request as ready for review January 13, 2025 03:10
Copy link
Contributor Author

fengmk2 commented Jan 13, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 force-pushed the 01-10-feat_server_usersession_model branch from 7571209 to b6b0270 Compare January 13, 2025 04:57
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_verificationtoken_model_instead_of_tokenservice branch 2 times, most recently from 638d63e to 4f02573 Compare January 13, 2025 09:10
@fengmk2 fengmk2 changed the base branch from 01-10-feat_server_usersession_model to 01-13-feat_server_verificationtoken_model January 13, 2025 09:10
@fengmk2 fengmk2 force-pushed the 01-13-feat_server_verificationtoken_model branch from 340d741 to db19a30 Compare January 13, 2025 09:12
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_verificationtoken_model_instead_of_tokenservice branch from 4f02573 to c0e324e Compare January 13, 2025 09:12
@fengmk2 fengmk2 force-pushed the 01-13-feat_server_verificationtoken_model branch from db19a30 to c2f28da Compare January 13, 2025 09:19
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_verificationtoken_model_instead_of_tokenservice branch from c0e324e to e72a1d4 Compare January 13, 2025 09:20
@fengmk2 fengmk2 force-pushed the 01-13-feat_server_verificationtoken_model branch from c2f28da to 6c60e35 Compare January 13, 2025 09:53
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_verificationtoken_model_instead_of_tokenservice branch from e72a1d4 to 6c02e21 Compare January 13, 2025 09:53
@fengmk2 fengmk2 force-pushed the 01-13-feat_server_verificationtoken_model branch from 6c60e35 to b77b475 Compare January 13, 2025 10:08
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_verificationtoken_model_instead_of_tokenservice branch from 6c02e21 to b44d04f Compare January 13, 2025 10:08
@fengmk2 fengmk2 force-pushed the 01-13-feat_server_verificationtoken_model branch from b77b475 to 68a3a81 Compare January 13, 2025 11:43
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_verificationtoken_model_instead_of_tokenservice branch from b44d04f to d22b3c6 Compare January 13, 2025 11:44
@fengmk2 fengmk2 force-pushed the 01-13-feat_server_verificationtoken_model branch from 68a3a81 to 9da27c9 Compare January 13, 2025 11:49
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_verificationtoken_model_instead_of_tokenservice branch from d22b3c6 to 6ab48f2 Compare January 13, 2025 11:49
@fengmk2 fengmk2 force-pushed the 01-13-feat_server_verificationtoken_model branch from 9da27c9 to f1d8b90 Compare January 13, 2025 11:53
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_verificationtoken_model_instead_of_tokenservice branch from 6ab48f2 to a5a9708 Compare January 13, 2025 11:53
Copy link

graphite-app bot commented Jan 14, 2025

Merge activity

@fengmk2 fengmk2 force-pushed the 01-13-feat_server_verificationtoken_model branch from f1d8b90 to b316922 Compare January 14, 2025 03:23
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_verificationtoken_model_instead_of_tokenservice branch from a5a9708 to 42336b5 Compare January 14, 2025 03:23
@fengmk2 fengmk2 force-pushed the 01-13-feat_server_verificationtoken_model branch from b316922 to 290b207 Compare January 14, 2025 03:39
@fengmk2 fengmk2 force-pushed the 01-13-refactor_server_use_verificationtoken_model_instead_of_tokenservice branch from 42336b5 to ee99b0c Compare January 14, 2025 03:39
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 69.09091% with 17 lines in your changes missing coverage. Please review.

Project coverage is 52.86%. Comparing base (290b207) to head (ee99b0c).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
packages/backend/server/src/core/auth/resolver.ts 65.71% 12 Missing ⚠️
...ages/backend/server/src/plugins/captcha/service.ts 20.00% 4 Missing ⚠️
...ackages/backend/server/src/core/auth/controller.ts 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9657      +/-   ##
==========================================
- Coverage   52.87%   52.86%   -0.01%     
==========================================
  Files        2197     2196       -1     
  Lines       99079    98956     -123     
  Branches    16835    16826       -9     
==========================================
- Hits        52385    52313      -72     
+ Misses      45288    45199      -89     
- Partials     1406     1444      +38     
Flag Coverage Δ
server-test 77.99% <69.09%> (-0.04%) ⬇️
unittest 32.22% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from 01-13-feat_server_verificationtoken_model to canary January 14, 2025 03:54
@graphite-app graphite-app bot merged commit ee99b0c into canary Jan 14, 2025
61 checks passed
@graphite-app graphite-app bot deleted the 01-13-refactor_server_use_verificationtoken_model_instead_of_tokenservice branch January 14, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:server test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants