Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simplest_tbf.qos.help #167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

diogosena
Copy link

Clarify that fq_codel is mandatory when using this script.

@tohojo
Copy link
Owner

tohojo commented Dec 21, 2023

It's not strictly speaking true that fq_codel is the only supported qdisc; rather, cake is explicitly not supported, so selecting that will cause a reset to fq_codel. So if we're updating the documentation it should be to say that cake is not supported...

@diogosena
Copy link
Author

It's not strictly speaking true that fq_codel is the only supported qdisc; rather, cake is explicitly not supported, so selecting that will cause a reset to fq_codel. So if we're updating the documentation it should be to say that cake is not supported...

In the header of the script itself, it is explicitly stated that the script is an fq_codel script:

# This is a single band fq_codel and ipv6 enabled shaping script for Ethernet
# gateways. This is nearly the simplest possible. With FQ_CODEL, the sparseness

@tohojo
Copy link
Owner

tohojo commented Jan 12, 2024 via email

@diogosena
Copy link
Author

diogosena commented Jan 12, 2024

diogosena @.***> writes:

It's not strictly speaking true that fq_codel is the only supported qdisc; rather, cake is explicitly not supported, so selecting that will cause a reset to fq_codel. So if we're updating the documentation it should be to say that cake is not supported... In the header of the script itself, it is explicitly stated that the script is an fq_codel script: # This is a single band fq_codel and ipv6 enabled shaping script for Ethernet # gateways. This is nearly the simplest possible. With FQ_CODEL, the sparseness
Sure, but it is not actually required. And the script only enforces it if cake is selected as the qdisc. You could run it with, say, sfq and that would work just fine (not that I'd recommend that, of course!). So we could write something like "It is recommended to use fq_codel as the qdisc for this script; if selecting cake as the qdisc, fq_codel will be automatically used instead."

maybe this? just trying to keep similar to other scripts help.

"This script forces fq_codel usage if cake is selected as qdisc."

@tohojo
Copy link
Owner

tohojo commented Jan 17, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants