-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use exactly 1.0.0-rc.3 hyper and update UI test #2086
Conversation
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Head branch was pushed to by a user without write access
Signed-off-by: hi-rustin <[email protected]>
@hi-rustin looks like some UI tests are failing now :/ Can you run |
hahah, Deadlock: #2085 Let me merge them. |
Signed-off-by: hi-rustin <[email protected]>
@jplatte Fixed. |
Unfortunately it seems like there are more trybuild errors. |
Signed-off-by: hi-rustin <[email protected]>
Yes, it causes by the different nightly versions. |
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Thanks! |
Motivation
close #2085
Because we don't have the Cargo.lock file so you try to build with Cargo, it will help you pick the
1.0.0-rc.4
to build the code.Then you will get an error:
Solution
Use a fixed version hyper. But if bump it is OK. I can also bump it to 1.0.0-rc.4.