Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove once_cell from jwt example #3014

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

Hmikihiro
Copy link
Contributor

Motivation

I think using std::sync::LazyLock can reduce dependency once_cell.

@fr0staman
Copy link

fr0staman commented Nov 6, 2024

std::sync::LazyLock introduced in 1.80.0, which axum MSRV with 0.8.0 is 1.75.0.

Maybe in future, but not right now, maybe

@ttys3
Copy link
Contributor

ttys3 commented Nov 6, 2024

since Rust it self growing fast, I think following newest Rust in main branch is good

@jplatte
Copy link
Member

jplatte commented Nov 6, 2024

I think we already don't enforce an MSRV other than stable for examples. The CI failure looks unrelated.

@jplatte jplatte changed the title remove once_cell from jwt example Remove once_cell from jwt example Nov 11, 2024
@jplatte jplatte enabled auto-merge (squash) November 11, 2024 16:46
@jplatte jplatte merged commit 0774e59 into tokio-rs:main Nov 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants