Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfg UnixListener tests for unix #3085

Merged
merged 2 commits into from
Dec 21, 2024
Merged

Conversation

2ndDerivative
Copy link
Contributor

Motivation

Fixes #3084

Solution

configged out the test for non-unix platforms

Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mladedav
Copy link
Collaborator

@2ndDerivative It seems there are still issues with some of the examples. Do you want to check that or I can take a look when I get to a Windows machine.

@2ndDerivative
Copy link
Contributor Author

@mladedav feel free to look at it, I couldn't figure it out yesterday because my build didn't like some dependency's build script

@2ndDerivative
Copy link
Contributor Author

@mladedav seems that fixed it. Eyeballed the cfgs since I am on windows 🤔

@mladedav mladedav merged commit 8af2f27 into tokio-rs:main Dec 21, 2024
18 checks passed
@2ndDerivative 2ndDerivative deleted the unix_test_fix branch December 21, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current main doesn't compile tests on windows
3 participants