Simplify TestClient implementation
#3096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to access all methods of the inner `response` field directly.
This returns the same as the `status()` fn of the inner `response`, so we might as well take advantage of the `Deref` implementation.
This returns essentially the same as the `headers()` fn of the inner `response`, so we might as well take advantage of the `Deref` implementation. This also avoids unnecessary cloning.
jplatte
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While working on some other stuff, I noticed that the
TestClientimplementation in theaxumcrate could be simplified a little bit …Solution
… by taking advantage of the
Dereftrait.