Refactor sync::batch_semaphore::Semaphore::poll_acquire
#7046
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I found the implementation of the low-level semaphore a bit hard to read compared to other code (possibly because it has been untouched for some years). It could potentially benefit from small rewrites, better documentation, and the like.
Solution
Well, I thought it would be faster to attempt a PR for an initial change, rather than opening an issue. But I have no expectations that it will be merged. :)
I reworked the
poll_acquire
method, these are the major changes:This probably needs a thorough review to make sure that I haven't messed up anything (or more likely, figure out what I have). If this kind of refactoring is accepted in core modules, I'm also happy to follow up with similar ones.