Skip to content

Commit

Permalink
fix: Add allow_cache to base registry get_request_feature_view
Browse files Browse the repository at this point in the history
Signed-off-by: tokoko <[email protected]>
  • Loading branch information
tokoko committed Feb 1, 2024
1 parent 9841637 commit cf0c441
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
4 changes: 3 additions & 1 deletion sdk/python/feast/infra/registry/base_registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,9 @@ def list_feature_views(

# request feature view operations
@abstractmethod
def get_request_feature_view(self, name: str, project: str) -> RequestFeatureView:
def get_request_feature_view(
self, name: str, project: str, allow_cache: bool = False
) -> RequestFeatureView:
"""
Retrieves a request feature view.
Expand Down
8 changes: 6 additions & 2 deletions sdk/python/feast/infra/registry/registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -528,8 +528,12 @@ def list_feature_views(
)
return proto_registry_utils.list_feature_views(registry_proto, project)

def get_request_feature_view(self, name: str, project: str):
registry_proto = self._get_registry_proto(project=project, allow_cache=False)
def get_request_feature_view(
self, name: str, project: str, allow_cache: bool = False
):
registry_proto = self._get_registry_proto(
project=project, allow_cache=allow_cache
)
return proto_registry_utils.get_request_feature_view(
registry_proto, name, project
)
Expand Down

0 comments on commit cf0c441

Please sign in to comment.