-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regex to allow for installation of MsBuild in Program Files (x86) #183
Conversation
@tomasbjerre Hi Tomas, I can't seem to get this PR to build correctly. Seems to be some kind of code formatting rule that prevents me from building. Not sure what the rule is, can you please take a look? |
9a72cea
to
3d0680b
Compare
The code will be formatted when you do Unless you are using Java 17: https://github.com/tomasbjerre/gradle-scripts/blob/master/src/main/resources/main.gradle#L132 |
Sigh...silly me, using the LTS Java. I probably should have Java 8 like everyone else... |
@tomasbjerre Thank you for your help. Built successfully now. |
There is a newer version of the Google Java Format plugin that runs on 17, but it will not run on 8. So if upgrading build script to that I can no longer verify builds with 8.... it is not perfect :) |
Can you supply a log that is currently not possible to parse: And add test case here: The test case that is currently implemented seems to have |
@tomasbjerre The new SDK style projects have a lot more warnings. I've added a unit test to test for incompatible nuget dependencies and incompatible 'in solution' dependencies. |
Thanks, releasing this now. |
@tomasbjerre Thank you very much. Very fast response. I would also appreciate it if you bump the Jenkins plug in as well. |
fixes #182