Tweaks & Fixes #10
Open
Tweaks & Fixes #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case user doesn't come to the site through checkout/confirm URL, The method in base controller checks for the existing orders and reset the cart if the payment has been received.
* It used to work before and now it's throwing an error saying uninitialized constant. Specified the classname explicitly (even though it may not be necessary).
TODO: Make it generic and flexible
Fixes the issue (may be temporarily) by checking for line items..
Cart get emptied if a promo code with higher value than the cart value get entered. Now checking the order state instead. Need sandbox testing.
* PayPal discount calculation * Not so great workaround for discount > item_total
Preferences can be entered through Spree > Admin > Configurations
* Mistakenly reverted the added routes. Committing again...
* Added attr_accessible to PaymentNotification (fix no mass assignment error) * Updated the borrowed medthods from checkout controller * Removed unwanted code
* The check_current_order method has no use when the spree receives payment confirmation from PayPal. Need find a different route to show the payment confirmation to the user.
* Cannot cycle through order.next and now payment/order status been set directly * Remove unwanted code * Some of the code extracted from Spree_PayPal_Express gem
* If the user visits a different URL after payment other than use the confirm payment url, the user won't get notified on payment. Need a fix. Currently commented out since old code is obsolete.
* Order number included with success URL * Success URL is a dynamically set URL based on Site URL. * If the user is logged in and paid user will be taken to view order screen. Otherwise to the root url with an appropriate message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO/IDEAS: If there's a possibility, may be we can make the payment_notifications a subclass of checkout and DRY it a bit by removing the redundant/borrowed code from checkout :-)