-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fuzzy search based on Levenshtein distance #645
base: main
Are you sure you want to change the base?
feat: fuzzy search based on Levenshtein distance #645
Conversation
I find it more confusing then helpful. For example, trying to match word
I'm really fine with what we have + #644. Implementing fulltext search features for a dumb single level list of short phrases is waay too much. I'd prefer a simple search implementation with slimmer |
4e05559
to
26327c4
Compare
It's less confusing without the cutoff. |
36083ae
to
af01ec0
Compare
I like wasting my time 🙃 As it turns out Levenshtein is much slower then Hamming, and the query length makes a huge difference. That's probably as good as a fuzzy search gets. |
d87b9b2
to
c3f6860
Compare
c3f6860
to
ba574f6
Compare
ba574f6
to
9de6198
Compare
Selecting the top search result allows one to immediatelly activating an item after typing without having to navigate to it.
9de6198
to
69e57a2
Compare
I don't know if that will ever go anywhere, but it's easier to test this way and it's a dedicated place to discuss this.
Ref. #625 (comment)
Depends on #644, but doesn't add text and hint characters together.