Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #456 #457

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

theolivenbaum
Copy link
Contributor

No description provided.

@theolivenbaum
Copy link
Contributor Author

@tomaszzmuda any ideas when this can be merged? Or if you can provide a way to set directly FFmpegPath && FFprobePath so ?

@tomaszzmuda
Copy link
Owner

Dremnor started working on solution of proper filtering that:
https://github.com/tomaszzmuda/Xabe.FFmpeg/pull/459/files
but somehow he gave up.
I can't merge that because it may be a breaking change for someone.

@theolivenbaum
Copy link
Contributor Author

Would't it be easier to just add another method to set directly both ffmpeg and ffprobe full paths instead of the current approach of passing a base-folder?
This way you wouldn't need to resort to a breaking change.

By the way, I ended up publishing ffmpeg to nuget yesterday (as we need it at build time to be able to sign the binaries), might be useful for someone: https://www.nuget.org/packages?q=Curiosity.FFmpeg.Runtimes

@tomaszzmuda
Copy link
Owner

That its already possible
image
It's not perfect though so I wanted to do it properly

@theolivenbaum
Copy link
Contributor Author

The issue is that's still only the executable name and not the full path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants