support macos #40
Merged
support macos #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will hopefully then allow users to install even if the man page sub-directories do not already exist in the install prefix location.
we write our own which is very hacky but hopefully functional
tomeichlersmith
force-pushed
the
39-install-macos
branch
from
fc35a2c
to
941106b
Compare
MacOS doesn't have realpath so it won't work that way
tomeichlersmith
changed the title
we don't need to be that extreme - removing the entire directory has ramifications for folks who may want to store other denv-related items in a .denv directory and it is better to just overwrite the things denv cares about (.denv/config and .denv/.gitignore)
also set xtrace so I can see what is being done in the CI
I think this could resolve the "permission denied" error we are seeing when the docker user is trying to read the _denv_entrypoint executable from within the container
also enable DENV_DEBUG if the workflow is being run in debug logging mode
I'm getting an odd "can't run /usr/local/bin/_denv_entrypoint because it is a directory" error when trying to run the denv tests on MacOS. I have a suspicion it has something to do with how docker on MacOS behaves for single-file volumes.
the install script is functional but I don't have access to a MacOS laptop to do more testing of `denv` itself, I am going to merge this branch with the install updates and then start a new issue for supporting macos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will hopefully then allow users to install even if the man page sub-directories do not already exist in the install prefix location.
After updating the install script and adding MacOS+docker to the CI testing, I discovered some other things that needed to be patched in order to support MacOS. The branch used for this PR will resolve #39 but also expand slightly to include supporting MacOS in
denvitself (hopefully, need to find a way to test more quickly than in GitHub CI).