Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert directory-based mounting of entrypoint #43

Merged
merged 2 commits into from
Sep 13, 2023
Merged

revert directory-based mounting of entrypoint #43

merged 2 commits into from
Sep 13, 2023

Commits on Sep 13, 2023

  1. revert mounting directory of entrypoint 

    if the directory the entrypoint is inside of is not mounted/created
within the container image, then docker responds with an error about how
the target directory does not exist. We can avoid this error by mounting
the single file which docker recognizes as a "symlink"-style mount and
can ignore the fact that its parent directories may not exist

docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "/home/tom/.local/bin/_denv_entrypoint": stat /home/tom/.local/bin/_denv_entrypoint: no such file or directory: unknown.
    @tomeichlersmith
    tomeichlersmith committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    405a5f5 View commit details
    Browse the repository at this point in the history

  2. add explicit check on passing environment variables into container

    @tomeichlersmith
    tomeichlersmith committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    f2b6447 View commit details
    Browse the repository at this point in the history