Firefox support

[xileftenurb]

No description provided.

[tomer8007]

Looks good, but - are you running this on Firefox, and the extension successfully blocks ads?

[xileftenurb]

Well, truth is, I did not test it, I don't know how...

[tomer8007]

You can test this using Firefox's developer page. You have instructions for example here.

[xileftenurb]

oh thank, I will check that

[xileftenurb]

I tested it (finally using the instruction found here -> https://extensionworkshop.com/documentation/develop/temporary-installation-in-firefox/

and it fails because it does not recognize "wsHook" as a variable.

What puzzle me is that this variable does not seem to exist in firefox, nor in chrome (when tapping "wsHook" in inspector, both return me undefined variable), but chrome does not seem to throw any error while running the script.

[tomer8007]

This variable is defined here:

spotify-web-ads-remover/content_script.js

Line 43 in 2c56b7c

var wsHook = {};

Perhaps there is a problem with the script injection on page load. You can take a look at the other addon here, in which it works. Hopefully this helps.

[xileftenurb]

I found the root of the problem ->
Content Security Policy: The page’s settings blocked the loading of a resource at inline (“script-src”). content_script.js:35:43

not sure how this could be fixed, since it will block any script injection.

[tomer8007]

Actually this makes me think about how it actually worked in Chrome so far, so I've pushed 66ad20f for completeness. Please try to see if it fixes anything on Firefox now.

[lorenanunez]

I downloaded the code and compiled for testing into Firefox, and it works. Can I create a pull request for uploading the manifest updated for working also on Firefox?

[tomer8007]

@lorenanunez You can open a separate pull request, given that you actually get ads blocked on Firefox

[mackdroid]

im encountering the same issue after installing from the main branch, installing on firefox, changing all instances of chrome -> browser and extension.getURL -> runtime.getURL

[mackdroid]

a possible workaround would be disabling content security policy browser wide, but i dont think thats a good idea

[mackdroid]

still occurs

[mackdroid]

oh i forgot to restart the browser, well anyways setting security.csp.enable to false in about:config and the extension works as flawlessly

[RodrigoDiazDVivar]

@tomer8007 would you consider uploading it to mozillas page please?

[tomer8007]

@RodrigoDiazDVivar It was already uploaded by another user, but looks outdated: https://addons.mozilla.org/he/firefox/addon/spotiads-by-tomer-public/

[RodrigoDiazDVivar]

@tomer8007 yes, i already had installed it, but it's outdated and doesn't work, sadly. That's why i came to ask you for it since you are the first one who would know notice about any new upgrades (also it's your addon too) :)

[tomer8007]

I don't want to upload it to the Firefox store right now because it will require more maintenance from my side. You are welcomed to try to port the new version yourself, it should be little work.

[RodrigoDiazDVivar]

ok thank you no problem. i will try it some day :)