Implement UI for multi-zone furnace controller #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it more readable on the settings dump, MSB-first schedule bit order is used. This way the bits can be read sequentiall from left to right, so the first half hour segment is bit 7, the second segment is bit 6 and so on.
Revert back to require setting the capacity manually in a template parameter instead of a variant with a specified maximum count. This saves around 240 Bytes of RAM.
In case of menus with more items than the number of displayed items (height), stepping down to a point where the menu began scrolling, then stepping up and stepping down again, caused the menu to draw the wrong items beginning from the current position.
To fix a possible oscillation scenario when over/undershoot is 0, add limits to hysteresis values. Also clamp the target temperature to avoid overheating or letting the room freeze.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.