fix: Improve AzureMonitorScraper Error Handling for Time Series Missing Requested Dimension Value #1503
tomkerkhoveci-code.yml
on: pull_request
Verify Codebase
1m 28s
Code Quality (R#)
3m 31s
Annotations
1 error, 8 warnings, and 10 notices
|
Code Quality (R#)
Issues found.
|
|
Code Quality (R#):
src/Promitor.Core/Metrics/Exceptions/MissingDimensionException.cs#L12
"[InvalidXmlDocComment] Cannot resolve parameter 'metricName'" on /home/runner/work/promitor/promitor/src/Promitor.Core/Metrics/Exceptions/MissingDimensionException.cs(12,291)
|
|
Code Quality (R#):
src/Promitor.Core/Metrics/Exceptions/MissingDimensionException.cs#L13
"[InvalidXmlDocComment] Parameter 'dimensionName' has no matching param tag in the XML comment for Promitor.Core.Metrics.Exceptions.MissingDimensionException.MissingDimensionException (but other parameters do)" on /home/runner/work/promitor/promitor/src/Promitor.Core/Metrics/Exceptions/MissingDimensionException.cs(13,381)
|
|
Code Quality (R#):
src/Promitor.Core/Metrics/Exceptions/MissingDimensionException.cs#L13
"[InvalidXmlDocComment] Parameter 'timeSeries' has no matching param tag in the XML comment for Promitor.Core.Metrics.Exceptions.MissingDimensionException.MissingDimensionException (but other parameters do)" on /home/runner/work/promitor/promitor/src/Promitor.Core/Metrics/Exceptions/MissingDimensionException.cs(13,414)
|
|
Code Quality (R#):
src/Promitor.Core/Metrics/Exceptions/MissingDimensionException.cs#L13
"[UnusedParameter.Local] Parameter 'timeSeries' is never used" on /home/runner/work/promitor/promitor/src/Promitor.Core/Metrics/Exceptions/MissingDimensionException.cs(13,414)
|
|
Code Quality (R#):
src/Promitor.Core/Metrics/Exceptions/MissingDimensionException.cs#L28
"[UnassignedGetOnlyAutoProperty] Get-only auto-property 'timeSeries' is never assigned" on /home/runner/work/promitor/promitor/src/Promitor.Core/Metrics/Exceptions/MissingDimensionException.cs(28,895)
|
|
Code Quality (R#):
src/Promitor.Core/Metrics/MeasuredMetric.cs#L69
"[PossibleMultipleEnumeration] Possible multiple enumeration" on /home/runner/work/promitor/promitor/src/Promitor.Core/Metrics/MeasuredMetric.cs(69,2465)
|
|
Code Quality (R#):
src/Promitor.Core/Metrics/MeasuredMetric.cs#L74
"[PossibleMultipleEnumeration] Possible multiple enumeration" on /home/runner/work/promitor/promitor/src/Promitor.Core/Metrics/MeasuredMetric.cs(74,2637)
|
|
Code Quality (R#):
src/Promitor.Tests.Unit/Metrics/MeasuredMetricTests.cs#L29
"[RedundantEmptyObjectOrCollectionInitializer] Empty object or collection initializer list is redundant" on /home/runner/work/promitor/promitor/src/Promitor.Tests.Unit/Metrics/MeasuredMetricTests.cs(29,1212)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentProgram.cs#L12
"[ArrangeNamespaceBody] Convert to file-scoped namespace" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(12,317)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentProgram.cs#L23
"[MemberCanBeProtected.Global] Method 'CreatePromitorWebHost' can be made protected" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(23,880)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentProgram.cs#L28
"[SuggestVarOrType_SimpleTypes] Use 'var' (simple types)" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(28,1260)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentProgram.cs#L54
"[MemberCanBePrivate.Global] Method 'DetermineHttpPort' can be made private" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(54,2323)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentProgram.cs#L66
"[SuggestVarOrType_BuiltInTypes] Use 'var' (built-in types)" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(66,2766)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentProgram.cs#L79
"[SuggestVarOrType_BuiltInTypes] Use 'var' (built-in types)" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(79,3190)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentStartup.cs#L12
"[ArrangeNamespaceBody] Convert to file-scoped namespace" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentStartup.cs(12,306)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentStartup.cs#L18
"[MemberCanBeProtected.Global] Property 'Configuration' can be made protected" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentStartup.cs(18,446)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentStartup.cs#L53
"[VirtualMemberNeverOverridden.Global] Virtual method 'CreateSerilogConfiguration' is never overridden" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentStartup.cs(53,1991)
|
|
Code Quality (R#):
src/Promitor.Agents.Core/AgentStartup.cs#L75
"[VirtualMemberNeverOverridden.Global] Virtual method 'EnrichTelemetry' is never overridden" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentStartup.cs(75,3329)
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
test-results
Expired
|
2.09 MB |
|