Skip to content
CI - Code

fix: Improve AzureMonitorScraper Error Handling for Time Series Missing Requested Dimension Value #1513

Sign in to view logs

fix: Improve AzureMonitorScraper Error Handling for Time Series Missing Requested Dimension Value

fix: Improve AzureMonitorScraper Error Handling for Time Series Missing Requested Dimension Value #1513

Triggered via pull request July 29, 2023 18:39
@tomkerkhovetomkerkhove
synchronize #2345
hkfgo:fix-azure-monitor-scraper-missing-dimension
Status Failure
Total duration 3m 54s
Artifacts 1

ci-code.yml

on: pull_request
Verify Codebase
1m 3s
Verify Codebase
Code Quality (R#)
3m 44s
Code Quality (R#)
Fit to window
Zoom out
Zoom in

Annotations

1 error, 4 warnings, and 10 notices
Code Quality (R#)
Issues found.
Verify Codebase: src/Promitor.Tests.Unit/Metrics/MeasuredMetricTests.cs#L20
Do not use Assert.Equal() to check for collection size. Use Assert.Single instead.
Verify Codebase: src/Promitor.Tests.Unit/Metrics/MeasuredMetricTests.cs#L20
Do not use Assert.Equal() to check for collection size. Use Assert.Single instead.
Verify Codebase: src/Promitor.Tests.Unit/Metrics/MeasuredMetricTests.cs#L20
Do not use Assert.Equal() to check for collection size. Use Assert.Single instead.
Code Quality (R#): src/Promitor.Tests.Unit/Metrics/MeasuredMetricTests.cs#L20
"[xUnit2013] Do not use Assert.Equal() to check for collection size. Use Assert.Single instead." on /home/runner/work/promitor/promitor/src/Promitor.Tests.Unit/Metrics/MeasuredMetricTests.cs(20,804)
Code Quality (R#): src/Promitor.Agents.Core/AgentProgram.cs#L12
"[ArrangeNamespaceBody] Convert to file-scoped namespace" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(12,317)
Code Quality (R#): src/Promitor.Agents.Core/AgentProgram.cs#L23
"[MemberCanBeProtected.Global] Method 'CreatePromitorWebHost' can be made protected" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(23,880)
Code Quality (R#): src/Promitor.Agents.Core/AgentProgram.cs#L28
"[SuggestVarOrType_SimpleTypes] Use 'var' (simple types)" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(28,1260)
Code Quality (R#): src/Promitor.Agents.Core/AgentProgram.cs#L54
"[MemberCanBePrivate.Global] Method 'DetermineHttpPort' can be made private" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(54,2323)
Code Quality (R#): src/Promitor.Agents.Core/AgentProgram.cs#L66
"[SuggestVarOrType_BuiltInTypes] Use 'var' (built-in types)" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(66,2766)
Code Quality (R#): src/Promitor.Agents.Core/AgentProgram.cs#L79
"[SuggestVarOrType_BuiltInTypes] Use 'var' (built-in types)" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentProgram.cs(79,3190)
Code Quality (R#): src/Promitor.Agents.Core/AgentStartup.cs#L12
"[ArrangeNamespaceBody] Convert to file-scoped namespace" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentStartup.cs(12,306)
Code Quality (R#): src/Promitor.Agents.Core/AgentStartup.cs#L18
"[MemberCanBeProtected.Global] Property 'Configuration' can be made protected" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentStartup.cs(18,446)
Code Quality (R#): src/Promitor.Agents.Core/AgentStartup.cs#L53
"[VirtualMemberNeverOverridden.Global] Virtual method 'CreateSerilogConfiguration' is never overridden" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentStartup.cs(53,1991)
Code Quality (R#): src/Promitor.Agents.Core/AgentStartup.cs#L75
"[VirtualMemberNeverOverridden.Global] Virtual method 'EnrichTelemetry' is never overridden" on /home/runner/work/promitor/promitor/src/Promitor.Agents.Core/AgentStartup.cs(75,3329)

Artifacts

Produced during runtime
Name Size
test-results Expired
2.1 MB