Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(parse): Remove extra key allocation #765

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

epage
Copy link
Member

@epage epage commented Jul 29, 2024

No description provided.

crates/toml_edit/src/inline_table.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/inline_table.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/inline_table.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/inline_table.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/inline_table.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/table.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/table.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/table.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/table.rs Fixed Show fixed Hide fixed
crates/toml_edit/src/table.rs Fixed Show fixed Hide fixed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10187827492

Details

  • 115 of 224 (51.34%) changed or added relevant lines in 14 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.2%) to 67.843%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/toml_edit/src/index.rs 3 4 75.0%
crates/toml_edit/src/parser/inline_table.rs 5 6 83.33%
crates/toml_edit/src/de/table_enum.rs 4 10 40.0%
crates/toml_edit/src/ser/key.rs 3 19 15.79%
crates/toml_edit/src/table.rs 36 70 51.43%
crates/toml_edit/src/inline_table.rs 29 80 36.25%
Files with Coverage Reduction New Missed Lines %
crates/toml_edit/src/index.rs 1 60.78%
crates/toml_edit/src/item.rs 1 68.1%
crates/toml_edit/src/internal_string.rs 4 29.55%
Totals Coverage Status
Change from base Build 10185912049: 0.2%
Covered Lines: 3711
Relevant Lines: 5470

💛 - Coveralls

@epage epage merged commit ae2dfb4 into toml-rs:main Jul 31, 2024
17 checks passed
@epage epage deleted the features-indexmap branch July 31, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants