Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json to support Angular 6.0.0 #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kristine-sl
Copy link

No description provided.

@tomwanzek
Copy link
Owner

@kristine-sl Will follow-up on this shortly.

@tomwanzek
Copy link
Owner

Need to assess the implications of the new service provisioning logic in Angular 6 (i.e. service declaring its own providedIn vs Module provisioning. Need to double-check any changes are not breaking for Angular <6.

@kristine-sl
Copy link
Author

Any updates on this?

@YaroslavDmytruk
Copy link

Hi, any updates on this ?

@neseleznev
Copy link

It's actually a good time to check support of 7.0 🚀

"@angular/compiler": "5.0.0",
"@angular/core": "5.0.0",
"@angular/compiler": "6.0.0",
"@angular/core": "6.0.0",
"codelyzer": "3.2.2",
"rxjs": "5.5.2",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are still using the old rxjs version - suggest that gets updated too and rev this lib to support 6 & 7+ instead.

@adumesny adumesny mentioned this pull request Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants