Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make docker-tests less verbose and easier to add new tests #311

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

skywhale
Copy link
Member

@skywhale skywhale commented Apr 18, 2024

  • Reorganize tests into functions
  • Replace userspace/kernel argument with --userspace option
  • Add --verbose option (the test currently prints 3483 lines, which is a bit overwhelming)
  • Take optional positional arguments to filter tests

Copy link
Member

@strohel strohel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks! Looked good, though my eye is not trained to spot problems in bash.

But this is test infra, so not worth to delay this by asking more eyes on this, though if @bschwind (or @mcginty) wants to have a (post-merge) look I'd certainly wouldn't protest.

Copy link
Collaborator

@mcginty mcginty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it but this looks so much cleaner and more maintainable, great stuff.

@skywhale skywhale merged commit 8ab0989 into main Apr 22, 2024
9 checks passed
@skywhale skywhale deleted the reorganize-docker-tests branch April 22, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants