Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Shorter log on property file not exists #357

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dzolo
Copy link

@dzolo dzolo commented Jul 19, 2023

Description

When property file included by configuration not exists then an ERROR log with long exception trace is populated.
The trace with java.io.FileNotFoundException is not useful as it contains no additional information and only increases the log size. This merge requests removed the trace from the ERROR log.

Linked Issues

Additional context

In qos-ch/logback this is implemented this way as well. See https://github.com/qos-ch/logback/blob/master/logback-core/src/main/java/ch/qos/logback/core/model/processor/PropertyModelHandler.java#L51

The trace with java.io.FileNotFoundException is not usefull as it contains no additional information and only increases the log size.
In qos-ch/logback this is implemented this way as well. See https://github.com/qos-ch/logback/blob/master/logback-core/src/main/java/ch/qos/logback/core/model/processor/PropertyModelHandler.java#L51
@dzolo dzolo changed the title Shorted log when property file not exists feat: Shorter log on property file not exists Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant